Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block API: Integrate variations with the / inserter #20583

Closed
gziolo opened this issue Mar 2, 2020 · 7 comments · Fixed by #23364
Closed

Block API: Integrate variations with the / inserter #20583

gziolo opened this issue Mar 2, 2020 · 7 comments · Fixed by #23364
Labels
[Feature] Block API API that allows to express the block paradigm. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@gziolo
Copy link
Member

gziolo commented Mar 2, 2020

Description

Follow-up for #16283.

With #19243, we integrate block variations API with the inserter. We still should seek a way to do a follow-up for the / inserter. At the moment, it only lists block types.

@gziolo gziolo added [Type] Enhancement A suggestion for improvement. [Feature] Block API API that allows to express the block paradigm. Needs Dev Ready for, and needs developer efforts labels Mar 2, 2020
@mtias
Copy link
Member

mtias commented Mar 7, 2020

It's a bit unfortunate that the quick inserter is so separate from the main one. Changes to what gets listed there should propagate more easily.

@apeatling
Copy link
Contributor

apeatling commented Apr 7, 2020

+1 to this. I just lost 40mins thinking I was doing something wrong because variations were not showing up, only to realize they don't show in the / inserter. 😆

@strarsis
Copy link
Contributor

strarsis commented May 5, 2020

Is there already terminology for this kind of inserter?
"/"-Inserter
Quick-Inserter
Shortcut-Inserter
Fast-Inserter
?

@nk-o
Copy link
Contributor

nk-o commented May 14, 2020

Really need this for our plugin with Gallery and Posts blocks:

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 11, 2020

Let's see if I got this right.
One block can show up in multiple ways through the inserter panel.
I remember testing a PR some time ago where the Navigation showed up twice regular horizontal and a vertical mode. This is actually much more a layout choice / styles choice.

EDIT:
Meaning there should only be one Navigation Block in the '/' and the Inserter panel. Variations/layouts would exist in a block. See my comment here: #20584 (comment)

The example @nk-o shares seems to me more like styles and should be added to the Styles Panel. Having 5 options for the same block in the inserter is not the level it should be at.

@strarsis
Copy link
Contributor

strarsis commented Jun 11, 2020

I remember testing a PR some time ago where the Navigation showed up twice regular horizontal and a vertical mode. This is actually much more a layout choice / styles choice.

Probably this issue.

@mtias
Copy link
Member

mtias commented Jun 11, 2020

@paaljoachim variations when exposed in inserter are to be considered new blocks, so they are meant to show up in all inserting contexts. What specific block choose to do is a separate conversation altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants