Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block: Long page titles cause horizontal scroll bars #19273

Closed
bobbingwide opened this issue Dec 20, 2019 · 3 comments
Closed

Navigation block: Long page titles cause horizontal scroll bars #19273

bobbingwide opened this issue Dec 20, 2019 · 3 comments
Labels
Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@bobbingwide
Copy link
Contributor

Describe the bug
When I created a Navigation with a top level page that had a very long title
a horizontal scroll bar appeared in the editor.

Additionally, the long page title is not at all well handled in the Page Attributes Parent Page drop down. It makes the drop down unusable. Should this be a separate issue?
See the screenshot.

To reproduce
Steps to reproduce the behavior:

  1. Create a top-level page with a very long title
  2. Add a new page
  3. Add a Navigation block
  4. Choose Create from all top-level pages
  5. See the horizontal scroll bar being added.

Expected behavior
The long page title wraps on spaces but doesn't force the wrap when there aren't any.
It either needs to wrap or be truncated.

Screenshots
image

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

  • Please add the version of Gutenberg you are using in the description.
    Development version.

  • To report a security issue, please visit the WordPress HackerOne program: https://hackerone.com/wordpress.

@talldan talldan added the [Type] Bug An existing feature does not function as intended label Feb 4, 2020
@talldan
Copy link
Contributor

talldan commented Feb 4, 2020

I've labelled as a bug, though with this kind of thing there's always a question of exactly when should the value be capped/truncated. And also what if a user wants a long title? Shouldn't they be allowed to have one?

I'll add the Needs Design Feedback to see if there's any specific feedback on how we might better handle this from a designer.

@talldan talldan added the Needs Design Feedback Needs general design feedback. label Feb 4, 2020
@wittwitsan
Copy link
Member

In design triage in slack, we agreed that wrapping the title (overflow-wrap) would be the easiest way to handle a very long title like what themes do.

@karmatosed
Copy link
Member

This is a duplicate of #18337. So let's close this one to ensure focus on that and get this resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants