Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Dismiss Welcome Modal in IE11 #19140

Closed
gwwar opened this issue Dec 13, 2019 · 3 comments · Fixed by #19201
Closed

Cannot Dismiss Welcome Modal in IE11 #19140

gwwar opened this issue Dec 13, 2019 · 3 comments · Fixed by #19201
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@gwwar
Copy link
Contributor

gwwar commented Dec 13, 2019

Describe the bug
The new welcome modal doesn't appear to be dismissible when clicking on the x, or background overlay in IE11

dismiss

To reproduce
Steps to reproduce the behavior:

  1. Make sure the NUX welcome will display for a user. wp.data.dispatch( 'core/nux' ).enableTips()
  2. When viewing in IE 11 try to click on the x or background overlay

Expected behavior
Modal dismisses

Additional context

  • Tested on master (b2ef0f5) using BrowserStack (Windows 10 / IE11)
@gwwar gwwar added the [Type] Bug An existing feature does not function as intended label Dec 13, 2019
@tellthemachines
Copy link
Contributor

Can confirm this is happening on Windows 10 / IE 11. Button is not clickable on hover, but can be tabbed to with the keyboard. The culprit is the margin-top: -56px set on components-guide_container which causes the container to overlay the button so that it becomes unclickable.

Closing on click outside is broken for all modals on IE, so must be an issue with the Modal component, or possibly withFocusOutside.

@aduth
Copy link
Member

aduth commented Dec 17, 2019

I'll plan to take a look at this today, if nobody's claimed it yet.

@aduth
Copy link
Member

aduth commented Dec 17, 2019

Fixes proposed at #19201

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants