-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing: Explore possible ways to integrate with React prerelease channels #18216
Comments
Hi! I would like to work on solving this issue |
Excellent 👍 |
Hi @gziolo I have a question, after I went through the link you have posted in a comment above I wonder which React PreRelease channel should be implemented for Gutenberg Next or Experimental. Thank you |
I guess it applies mostly to |
Ok, thank you! |
Hi @gziolo. I have been looking into this issue for the past 2 weeks and I have another question. So far I updated all react 16.9.0 to experimental. I stack on the testing part. I just wonder if I have to write any tests, because it seems that test against updated react package already exist in this file. Moreover when I try to run tests (npm run test-unit) locally it is failing because of
|
@lozinska, can you share your code, it's hard to tell what might go wrong otherwise. If you run the same tests on masters you should see tons of them. It feels like your setup doesn't quite work as it should. |
Hi @gziolo. Here is my code snippets where I updated react version. class-vendor-script-filename-test.php And this is a screenshot of the problem I'm running into while i execute command |
@gziolo another question is: after I update React version to "experimental" do I have to create any additional test that will check failures towards updates in "experimental"? Thank you |
I have no idea what might be wrong here. You probably need to start with the fresh |
Let's close this one since we depend too much on React Native releases which are always delayed a few weeks compared to the React core releases. |
There was an announcement from the React team about official prerelease channels:
https://twitter.com/reactjs/status/1186721158210576385
https://reactjs.org/blog/2019/10/22/react-release-channels.html
At first glance, it seems like this is it mostly npm install'ing it and then poking around to make sure nothing explodes? Everything builds, all tests pass, etc.
According to the document, in our case, we would also need to tweak PHP code as well, because we use
react
as an external library in the webpack config and enqueue it using WordPress API. Related PR withreact
version upgrade might be useful here to better explain it:#16982
This topic was discussed during the last weekly WordPress core JS chat (link requires registration):
https://wordpress.slack.com/archives/C5UNMSU4R/p1572357832196200
The text was updated successfully, but these errors were encountered: