Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate on convert block message and actions #17604

Closed
karmatosed opened this issue Sep 26, 2019 · 6 comments
Closed

Iterate on convert block message and actions #17604

karmatosed opened this issue Sep 26, 2019 · 6 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance

Comments

@karmatosed
Copy link
Member

If a block has issues and needs to be converted, you see the following:

image

I would love to see how this could be iterated. For example, do we need to hide actions behind a drop-down? Could resolve just be the option and 'best option' by default?

@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Sep 26, 2019
@mapk mapk added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels Oct 8, 2019
@mapk
Copy link
Contributor

mapk commented Oct 8, 2019

Definitely some confusion around this. After talking about this in today's Design Team slack meeting, there was a desire to improve the interaction. Some questions we had included:

  1. Shouldn't the block try to "resolve" automatically? If so, then why is there a "Resolve" button?
  2. What's the difference between "Resolve" and "Attempt Block Recovery"?

Let's iterate on this. 👍

@melchoyce melchoyce added the Needs Technical Feedback Needs testing from a developer perspective. label Dec 2, 2019
@efc
Copy link

efc commented Dec 16, 2019

In my experience the difference between "resolve" and "attempt block recovery" is that "resolve" almost never works and "attempt block recovery" has never failed me. I'm not at all sure what they do under the covers, but I am puzzled that WP does not automatically give "attempt block recovery" a try before complaining at all. (See issue #16425)

@karmatosed karmatosed added [Type] Copy Issues or PRs that need copy editing assistance Good First Issue An issue that's suitable for someone looking to contribute for the first time and removed Needs Design Needs design efforts. labels Dec 27, 2019
@talldan
Copy link
Contributor

talldan commented Apr 21, 2020

As mentioned, there's some overlap between this and #16425.

I don't see any barriers to making 'Attempt Block Recovery' the more prominent option. A question would be whether the diff should/could be used when using 'Attempt Block Recovery':
Screenshot 2020-04-21 at 2 30 20 pm

Other less used options could potentially be moved to the block settings menu, which is already quite contextual about which options are shown.

@talldan talldan removed the Needs Technical Feedback Needs testing from a developer perspective. label Apr 21, 2020
@talldan
Copy link
Contributor

talldan commented Apr 21, 2020

Shouldn't the block try to "resolve" automatically? If so, then why is there a "Resolve" button?

I think this is protecting against unexpected data loss, e.g. if the user has edited their HTML outside the block editor, reloading that post and automatically resolving could result in the content being changed.

What's the difference between "Resolve" and "Attempt Block Recovery"?

Good question!

It looks like Attempt Block Recovery tries to recreate the block from scratch using the block attributes that the editor was able to recover/parse. This option seems like it could result in some lost data if the attributes couldn't be parsed, but at least the correct block will be created.

It looks like Convert To Blocks treats the HTML almost as though it was pasted content. I've noticed sometimes with this option that invalid columns/gallery blocks can be converted to list blocks, so that might explain why—it might be ignoring the type of block and is trying to 'guess' what type the content is.

@mapk
Copy link
Contributor

mapk commented Apr 30, 2020

A question would be whether the diff should/could be used when using 'Attempt Block Recovery':

I think that's a more advanced option that can be integrated down the road.

@mtias
Copy link
Member

mtias commented Mar 3, 2021

I don't think we have a lot of actionable things here. Better defaults are a bit dependant on the block type, which could be improved if we have this segmentation in place #21703.

@mtias mtias closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

No branches or pull requests

6 participants