Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tooling: Further improve asset file produced by Webpack for each entry point #17454

Closed
gziolo opened this issue Sep 16, 2019 · 2 comments
Closed
Labels
Needs Dev Ready for, and needs developer efforts [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Type] Build Tooling Issues or PRs related to build tooling

Comments

@gziolo
Copy link
Member

gziolo commented Sep 16, 2019

In #17298 we started to generate asset files for the WordPress packages in PHP format with the list of all dependencies and stable version for each file which updates when it's source code changes.

There are some follow-up tasks which we can work on to further improve developer experience as summarized by @nerrad in #17298 (review):

Summarizing what can be iterated on in future pulls:

  • flagging what assets have translations (likely can be done by detecting @wordpress/i18n as a dependency)
  • generating/returning the handle to use for registering the asset (essentially that is already the case for the dependency arrays)
  • potentially introducing a new asset php api for registering assets using these generated files (wp_register_asset?).
@gziolo gziolo added [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Type] Build Tooling Issues or PRs related to build tooling Needs Dev Ready for, and needs developer efforts labels Sep 16, 2019
@jrchamp
Copy link
Contributor

jrchamp commented Sep 16, 2019

The asset file produced doesn't appear to generate all dependencies when using the wp.data and other globals as described in the documentation. #17423

@gziolo
Copy link
Member Author

gziolo commented Mar 10, 2020

We can close it now since all those points were resolved in WordPress core and the last item is going to be tackled separately.

@gziolo gziolo closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

No branches or pull requests

2 participants