Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Links Block: Add sizing options #17276

Closed
jasmussen opened this issue Aug 30, 2019 · 0 comments · Fixed by #25921
Closed

Social Links Block: Add sizing options #17276

jasmussen opened this issue Aug 30, 2019 · 0 comments · Fixed by #25921
Assignees
@mkaz
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

In #16897 a "social links" block is likely to land in its first version.

Based on feedback for that first version, we'd like to explore some additional features.

One such feature is to add a size control to the sidebar, to give more control over how big the icons are. Such a size control should probably share DNA with the font size picker and suggest preset sizes rather than have a pixel slider, as the icons inside render best at specific sizes, usually even pixel numbers and multiples of .5x.
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Aug 30, 2019
This was referenced Aug 30, 2019
Closed
Merged
@jasmussen jasmussen mentioned this issue Sep 25, 2019
Closed
@draganescu draganescu added the [Block] Social Affects the Social Block - used to display Social Media accounts label Apr 23, 2020
@mtias mtias added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Aug 30, 2020
@mkaz mkaz mentioned this issue Oct 7, 2020
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaz mkaz

Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Social Links: Add ability to change social icon sizes WordPress/gutenberg
4 participants
@mkaz @draganescu @mtias @jasmussen