Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing flow: hitting backspace causes block to lose heading when prior block is empty #16436

Closed
ellatrix opened this issue Jul 5, 2019 · 3 comments · Fixed by #55134
Closed

Writing flow: hitting backspace causes block to lose heading when prior block is empty #16436

ellatrix opened this issue Jul 5, 2019 · 3 comments · Fixed by #55134
Assignees
@ellatrix
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@ellatrix
Copy link
Member

ellatrix commented Jul 5, 2019 •
edited
Loading

Describe the bug

This is a small writing flow issue.

To reproduce

  1. Create an empty paragraph
  2. Press Enter
  3. Create a heading with some text
  4. Put the caret at the start of the heading
  5. Press Backspace

Expected behavior

The block should be preserved if the previous block is empty.
@ellatrix ellatrix added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Jul 5, 2019
@paaljoachim
Copy link
Contributor

Hey Ella
Is this issue still relevant?

@annezazu
Copy link
Contributor

Noting that this can still be replicated with 6.3 RC 1:

Screen.Recording.2023-07-18.at.5.47.14.PM.mov

@annezazu annezazu mentioned this issue Aug 3, 2023
Closed
42 tasks
@annezazu annezazu changed the title Backspace: block loses heading when previous block is empty Writing flow: block loses heading when previous block is empty Aug 3, 2023
@annezazu annezazu changed the title Writing flow: block loses heading when previous block is empty Writing flow: hitting backspace causes block to lose heading when prior block is empty Aug 3, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 4, 2023
@bangank36
Copy link
Contributor

@ellatrix Is the issue still worth fixing? I can reproduce it on latest GB

Below Paragraph Below Empty Paragraph
Kapture 2023-08-23 at 19 55 20 Kapture 2023-08-23 at 19 53 33

Expected

The heading should not be merged with previous block if paragraph is empty
Kapture 2023-08-23 at 20 04 55

@bangank36 bangank36 mentioned this issue Aug 28, 2023
Closed
@annezazu annezazu moved this to In Progress in WordPress 6.4 Editor Tasks Aug 30, 2023
@annezazu annezazu moved this from In Progress to Punted to 6.5 in WordPress 6.4 Editor Tasks Sep 25, 2023
@ellatrix ellatrix mentioned this issue Oct 6, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 6, 2023
@github-project-automation github-project-automation bot moved this from Punted to 6.5 to Done in WordPress 6.4 Editor Tasks Oct 9, 2023
@geriux geriux mentioned this issue Nov 24, 2023
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellatrix ellatrix

Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
No open projects
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Writing flow: preserve block when merging into empty paragraph WordPress/gutenberg
5 participants
@jordesign @ellatrix @paaljoachim @bangank36 @annezazu