Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Replace edit image icon with swap icon for multiple blocks #15954

Closed
arunsathiya opened this issue Jun 2, 2019 · 2 comments
Closed

Enhancement: Replace edit image icon with swap icon for multiple blocks #15954

arunsathiya opened this issue Jun 2, 2019 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@arunsathiya
Copy link
Contributor

arunsathiya commented Jun 2, 2019 •
edited
Loading

On #15614 (comment), I noticed that we are now replacing the edit image icon with a "swap" icon, to indicate that the icon is more about replacing the image in the block rather than editing the image itself. This is a great move!

Although, I see this new icon only on the image block at the moment.

Block name Image
Image Screenshot 2019-06-02 at 14 50 01

It's not seen on any other image blocks like the ones below:

Block name Image
Cover Screenshot 2019-06-02 at 14 50 37
Gallery Screenshot 2019-06-02 at 14 50 17
Media & Text Screenshot 2019-06-02 at 14 49 47

For consistency reasons, all blocks should have the swap icon on it, instead of "edit" icon.
@swissspidy swissspidy added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Feature] Blocks Overall functionality of blocks labels Jun 3, 2019
@swissspidy
Copy link
Member

Thanks for your report! Please note that we are already tracking this in #14795.

@arunsathiya
Copy link
Contributor Author

Ah, I tried searching for that ticket with multiple keywords but hadn't noticed that one. Thanks, Pascal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swissspidy @arunsathiya