Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint-js task lints build/ directory #15407

Closed
iandunn opened this issue May 3, 2019 · 3 comments · Fixed by #15977
Closed

lint-js task lints build/ directory #15407

iandunn opened this issue May 3, 2019 · 3 comments · Fixed by #15977
Assignees
@gziolo
Labels
[Tool] WP Scripts /packages/scripts [Type] Bug An existing feature does not function as intended

Comments

@iandunn
Copy link
Member

iandunn commented May 3, 2019

Describe the bug

Running the JS linter will lint the build/ folder, resulting in hundreds of errors because it's minified, etc.

Expected behavior

The build/ folder should be ignored by the linter config.
@iandunn iandunn added [Type] Bug An existing feature does not function as intended [Tool] WP Scripts /packages/scripts labels May 3, 2019
@swissspidy
Copy link
Member

In Gutenberg or did you mean in general? The .eslintignore in Gutenberg excludes build directories already, but I don't think there's any such default configuration in the scripts package.

@iandunn
Copy link
Member Author

iandunn commented May 3, 2019

Not with Gutenberg, but in general, when using wp-scripts to build blocks or other plugins that use wp.element, wp.component, etc. For example.

@gziolo
Copy link
Member

gziolo commented May 6, 2019 •
edited
Loading

I would expect the same issue for lint-styles as well.

@gziolo gziolo changed the title lint:js task lints build/ directory lint-js task lints build/ directory May 6, 2019
@gziolo gziolo mentioned this issue Jun 4, 2019
Merged
@gziolo gziolo self-assigned this Jun 4, 2019
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Jun 4, 2019
@gziolo gziolo removed [Status] In Progress Tracking issues with work in progress labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gziolo gziolo

Labels
[Tool] WP Scripts /packages/scripts [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scripts: Ignore linting files located in build folders by default WordPress/gutenberg
3 participants
@iandunn @gziolo @swissspidy