Saving tags before post creates unused/unwanted tags

[iandunn]

Describe the bug

New tags are saved in the database before the user has indicated that they should be.

To reproduce
Steps to reproduce the behavior:

1. Add or edit a post
2. Open the Tags control in the sidebar
3. Type a tag with a typo, e.g., javascritp
4. Press , to start typing the next tag
5. Notice you made a typo and remove the previous tag
6. Re-type the tag correctly, javascript, press enter
7. Save draft
8. Browse to Posts > Tags screen

There's be 2 new tags, javascript and javascritp.

Expected behavior

New tags should not be created until the user has manually triggered a save of the post (whether thats as a draft, or publishing).

[mapk]

Thanks @iandunn! I've experienced this as well in addition to having tags completely vanish as I'm adding more tags to the post.

This seems to be a development bug and doesn't require any design feedback. I'll adjust the labels.

[iandunn]

Ah, I wasn't sure if saving tags before the post was intentional or not. 👍

[gwwar]

Verified that we do create tags on , or enter

tag.mp4

[paaljoachim]

@Mamaduka George is planning on working on improving the Tags feature in Gutenberg. Here is the issue for it. I linked to my comment. #8867 (comment)
It would be great for him to have this in mind as he creates the PR.
Thanks!

[paaljoachim]

There is now a new PR by @Mamaduka George here: #30598

It also tackles the bug in this issue.

[annezazu]

@paaljoachim you linked to a PR that's been merged but I'm still able to replicate this problem in 10.6.1 which should have the fix:

Screen.Recording.2021-05-17.at.9.44.41.PM.mov

Tagging you in case you have more insight here! If not, let's keep this open since it doesn't seem resolved.

[Mamaduka]

Hi, @annezazu

Unfortunately, my PR didn't solve this issue. It is an enhancement for Tag settings.

The main problem here's is that we can't create terms when saving/creating posts via REST API. It means creating terms before a post is saving and providing IDs for the API call.

Like @iandunn suggested, we should defer tag creation until the user triggers save. I've some ideas on how to do this, but I'm not 100% sure about the best option.

I'm open to suggestions and happy to work on PR.