Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient color contrast in the options menu #15274

Closed
karlgroves opened this issue Apr 30, 2019 · 1 comment
Closed

Insufficient color contrast in the options menu #15274

karlgroves opened this issue Apr 30, 2019 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@karlgroves
Copy link

Insufficient color contrast in the options menu

  • Severity: Medium
  • Affected Populations:
    • Low-Vision
    • Cognitively
  • Platform(s):
    • All / Universal
  • Components affected:
    • Tools and Options

Issue description

Shortcut key instructions in the "Visual Editor" and "Keyboard
Shortcuts" items of the Options menu have insufficient color contrast,
below the minimum threshold of 4.5:1 for text:

  • "Ctrl+Shift+Alt+M" and "Shift+Alt+H" rendered text: #a0a3a6 (light gray) on #fff (white): 2.5:1

Sufficient color contrast is important for users who have low-vision or
are color-blind, because text with a low contrast ratio may be difficult
or impossible for such users to see.

Issue Code
    /* media all */
    .components-menu-item__shortcut {
        ...
        opacity: 0.5;
        ...
    }

    /* media all */
    :not(:disabled):not([aria-disabled=true]).components-menu-item__button.components-icon-button:focus, :not(:disabled):not([aria-disabled=true]).components-menu-item__button:focus {
        color: #191e23;
        ...
    }

Remediation Guidance

Increase the opacity, or remove the opacity and use a mid-gray color, so
that the text has a minimum contrast ratio of 4.5:1.

Recommended Code
    /* media all */
    .components-menu-item__shortcut {
        ...
        opacity: 1;
        ...
    }

    /* media all */
    :not(:disabled):not([aria-disabled=true]).components-menu-item__button.components-icon-button:focus, :not(:disabled):not([aria-disabled=true]).components-menu-item__button:focus {
        color: #767676;
        ...
    }

Relevant standards

Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-55 in Tenon's report

@gziolo gziolo added the Needs Accessibility Feedback Need input from accessibility label Apr 30, 2019
@mapk mapk added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label May 2, 2019
@mapk
Copy link
Contributor

mapk commented May 2, 2019

I can't find the PR, but it appears that this has been resolved. This is also a duplicate of #10576.

Resolved examples:

Screen Shot 2019-05-01 at 5 54 37 PM

Screen Shot 2019-05-01 at 5 54 46 PM

@mapk mapk closed this as completed May 2, 2019
@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed Needs Accessibility Feedback Need input from accessibility labels May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

4 participants