Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Interaction: ArrowLeft in multi-line selection prematurely triggers multi-selection #14871

Closed
aduth opened this issue Apr 8, 2019 · 3 comments · Fixed by #14906
Closed
Assignees
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@aduth
Copy link
Member

aduth commented Apr 8, 2019

Possibly related: #12322, #14450

Describe the bug

In a paragraph block containing multiple lines of text, a selection spanning multiple lines may prematurely trigger multi-selection when expanding that selection using Shift+ArrowLeft

To reproduce

  1. Navigate to Posts > Add New
  2. Click the writing prompt
  3. Add a paragraph with some text
  4. Add a second paragraph with at least two lines of text (does not make a difference whether that occurs naturally or by Shift+Enter line break)
  5. Starting in the second line of text, create a selection using Shift+ArrowLeft
  6. Continue pressing ArrowLeft while holding Shift
  7. Observe that as the selection expands into the first line of text, multi-selection occurs prematurely

Expected behavior

I can expand the selection until reaching the start of the first line of the paragraph. Only at that point should another ArrowLeft expand to create the multi-selection.

Screenshots

arrow-left-multi

Desktop:

  • OS: macOS Mojave 10.14.4 (18E226)
  • Browser: Chrome Version 73.0.3683.103 (Official Build) (64-bit)
  • Version: master (1df3021)

Additional context

The same issue does not appear to occur in the reverse direction, i.e. Shift+ArrowRight does not trigger multi-selection prematurely. However, it never triggers the multi-selection, even when reaching the end of the paragraph, which is similarly an unexpected behavior.

@aduth aduth added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Apr 8, 2019
@aduth
Copy link
Member Author

aduth commented Apr 8, 2019

cc @ellatrix

@ellatrix
Copy link
Member

@aduth I'll have a look.

@ellatrix
Copy link
Member

After looking closer, this actually appears to be a regression caused by #14462, which unfortunately no e2e test caught.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants