Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Block: Logos #14665

Closed
frontdevde opened this issue Mar 27, 2019 · 7 comments
Closed

New Block: Logos #14665

frontdevde opened this issue Mar 27, 2019 · 7 comments
Labels
New Block Suggestion for a new block

Comments

@frontdevde
Copy link
Contributor

frontdevde commented Mar 27, 2019

Is your feature request related to a problem? Please describe.

I want to propose a new block, the "logos" block. The "logos" block is a list of logos that can be used to, e.g., display logos of customers, partners, sponsors, etc. and link out to them directly.

logos-wireframe (1)

Describe the solution you'd like

The initial functionality for this block should include:

  • Ability to add a link to an external URL to each logo
  • TBD...

Visually we'd want to ensure that:

  • Logos aren't cropped and are centered on the cross-axis
  • Logos have a maximum width, so they do not scale to full width
  • When there are only a few logos, we’d like them to be centered

Describe alternatives you've considered

With the currently existing set of blocks, it is not possible to achieve a visually pleasing result with a good user experience. We tried a combination of Columns > Column > Image blocks for a similar looking section. The user experience of adding/removing logos, unfortunately, was far from intuitive. Similar issues arose when we tried to use the gallery block for this purpose. In addition, Gallery images crop by default and can't be linked to an external URL. When the crop option is “off” the images are placed on the cross-end line on the site. For logos, it’d make more sense if the logos are centered on the cross-axis. When the gallery has a small number of images, say 3, the CSS makes images to fill the space. This makes sense for a gallery, but not with logos because the logos become big. When there are only a few logos, we’d like them to be centered rather than to be left aligned.

@frontdevde frontdevde added the New Block Suggestion for a new block label Mar 27, 2019
@frontdevde
Copy link
Contributor Author

frontdevde commented Mar 27, 2019

Input and feedback is welcome! I'm working with @thomasguillot to further define the functionality and figure out a good UX for the block options, etc.

@aduth
Copy link
Member

aduth commented Mar 27, 2019

@paaljoachim
Copy link
Contributor

Great initiative!

My initial response is mixed.
As it would be great to get this working with image blocks next to each other with aligning all of them to the left. Which would mean looking at various ways in how to improve the image block.

But I think that adding a logos block is a good idea as an user will likely look for specific blocks to do specific things. Such as adding logos to the bottom of a page.

Personally I would prefer an image block that could do this in addition to a logos block.

There has been some talk of what belongs in core and not. Well there are lots of video embed blocks and it seems one can just paste an url from a lot of sites into the default paragraph block and have the video embed just show up instead of specifically selecting an embed block. So I am all for more variety of useful blocks.

@mrleemon
Copy link
Contributor

Wouldn't make more sense to add the ability to link to external sites in the already present Gallery block?

@strarsis
Copy link
Contributor

strarsis commented Apr 2, 2019

Very related: Add SVG image file support to WordPress core?
Currently I have to use a separate plugin for allowing SVG files.

@paaljoachim
Copy link
Contributor

Related:
"Add an Icons block"
#16484

@mtias
Copy link
Member

mtias commented Jul 13, 2021

It seems the icon block would cover most of this use case.

@mtias mtias closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Block Suggestion for a new block
Projects
None yet
Development

No branches or pull requests

6 participants