Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When another editor takes over screen, the "All Posts" button doesn't make sense #14345

Closed
mapk opened this issue Mar 8, 2019 · 2 comments
Closed
Assignees

Comments

@mapk
Copy link
Contributor

mapk commented Mar 8, 2019

Problem
When I had a post taken over by another editor, I received a modal popup on the screen. I didn't get a screenshot but got a screenshot of the popup if I was going to take over the screen.

screen shot 2019-03-08 at 7 07 51 am

The "All Posts" button didn't make sense to me. The other two buttons are a call to action, but All Posts is not. And in the screen where another user takes over your editing, the button seems to make less sense b/c it's displayed by itself.

Describe the solution you'd like
Can the text be reworded to request an action instead? Maybe something like "View All Posts"?

@mapk mapk added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Mar 8, 2019
@mapk mapk self-assigned this Mar 8, 2019
@michelleweber
Copy link

Agree, good call. I think "View all posts" works (or "Return to posts list" if you want to be super clear (and don't mind the button getting longer) is an improvement.

I wonder if the best way to go, though, might be "Exit post editor." It's simple, and probably makes the most sense as an option -- if you get this pop-up, it means you're either staying on this page, leaving this page, or opening a new window (previewing). So let's just have the buttons map to those three options.

@mapk mapk removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Mar 8, 2019
@mapk
Copy link
Contributor Author

mapk commented Mar 8, 2019

Thanks @michelleweber! I've got a PR ready that shows these changes.

When taking over a screen

screen shot 2019-03-08 at 7 56 23 am

When having screen taken over from you

screen shot 2019-03-08 at 7 55 58 am

I went with "Exit the Editor" because these modals are used across Pages, Posts, and Portfolios.

Props: @kjellr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants