Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider only assigning animation styles after the page has fully loaded #13925

Closed
kjellr opened this issue Feb 18, 2019 · 2 comments
Closed
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Feb 18, 2019

Describe the bug

Currently, some animation styles are set to trigger as soon as their element first appears. For example:

  • When fullscreen mode is active, the body is set to fade in immediately.
  • When the sidebar is open, it is set to slide in from the right.

These animations were mostly designed to occur after the user performs an action. The fullscreen fade was to happen when someone toggles fullscreen, and the sidebar was meant to animate in when it's toggled open.

Because of the way these are built, they also trigger upon the initial page load. They're both quick animations, so it's a major problem, but we should consider adjusting these animations so that they don't occur in this context.

A potential fix would be to hooking their appearance into a new is-loaded body class that only appears after the page is loaded, or something similar.

Screenshot:
(GIF has been slowed down to show effect)

reload

@kjellr kjellr added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. labels Feb 18, 2019
@kjellr kjellr added General Interface Parts of the UI which don't fall neatly under other labels. and removed Needs Design Feedback Needs general design feedback. labels Mar 4, 2019
@draganescu
Copy link
Contributor

@kjellr is this still an issue as I've been unable to repro?

@kjellr
Copy link
Contributor Author

kjellr commented Apr 22, 2020

Yeah, I don't see this happening anymore. 👍

@kjellr kjellr closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants