Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: Possible race condition with in-flight data resolution #12984

Closed
aduth opened this issue Dec 18, 2018 · 2 comments
Closed

Data: Possible race condition with in-flight data resolution #12984

aduth opened this issue Dec 18, 2018 · 2 comments
Labels
[Package] Data /packages/data [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Dec 18, 2018

From Automattic/wp-calypso#29445 (comment) :

There is just one race condition bug that remains: if a request for entities from site ID=1 is in flight, and we switch to site ID=2, then the response from site ID=2 will be received into store with site ID=2!

The cache invalidation code in #10089 probably has a similar bug: it won't invalidate resolution for selector whose request is in flight. There can be "get a list" and "add to list" requests happening at the same time, and if their "issue request from client", "perform request on server" and "receive response on client" are performed in a certain order, the resulting state will miss the just-added entity.

cc @jsnajdr

@aduth aduth added [Type] Bug An existing feature does not function as intended [Package] Data /packages/data labels Dec 18, 2018
@paaljoachim
Copy link
Contributor

I assume this issue is not relevant any longer.

@gziolo

@mrfoxtalbot
Copy link

mrfoxtalbot commented Aug 1, 2022

It looks like the linked PR fixes this so I am going to go ahead and close it.

It this is still relevant, @Copons, @paaljoachim, @aduth, please feel free to re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Data /packages/data [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants