Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undoing list block creation causes loss of keyboard focus #12618

Closed
brianhogg opened this issue Dec 5, 2018 · 2 comments
Closed

Undoing list block creation causes loss of keyboard focus #12618

brianhogg opened this issue Dec 5, 2018 · 2 comments
Labels
[Block] List Affects the List Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended

Comments

@brianhogg
Copy link

Describe the bug
If you type - (dash) then space, the paragraph block converts into a list item block. But if you then Cmd+Z to undo (ie. you just want a dash not a special bullet block) you lose keyboard focus and have to mouse into the block.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new paragraph block
  2. Type - then a space
  3. Press Cmd+Z (OSX)
  4. See keyboard focus is lost and you can no longer type in the reverted paragraph block

Expected behavior
Keyboard cursor remains in the paragraph block

Desktop (please complete the following information):

  • OS: MacOSX 10.13.6
  • Browser: Chrome
  • Version 70.0.3538.110 (Official Build) (64-bit)
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Dec 5, 2018
@designsimply
Copy link
Member

Tested and confirmed that typing - or * then pressing Cmd+Z looses keyboard focus.

12618
Tested with WordPress 4.9.8 and Gutenberg 4.6.1 master @ 874321773 using Firefox 63.0.3 on macOS 10.13.6.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Block] List Affects the List Block [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. [Type] Enhancement A suggestion for improvement. labels Dec 5, 2018
@jorgefilipecosta
Copy link
Member

Hi @brianhogg, @designsimply thank you for reporting and testing this issue. I think this is a general RichText problem of focus not being managed and is covered in #9740. I'm going to close this issue for now so we can converge in the other issue which is more general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants