Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeControl: input field should be focused when thumb is pressed #12433

Closed
davewhitley opened this issue Nov 29, 2018 · 3 comments
Closed

RangeControl: input field should be focused when thumb is pressed #12433

davewhitley opened this issue Nov 29, 2018 · 3 comments
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.

Comments

@davewhitley
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When the thumb of the range control is clicked, the user can use the arrow keys to move left/right. The input field should also be focused, allowing the user to type in a number.

Describe the solution you'd like
After clicking on the thumb (the circle), the user should be able to use the arrow keys or type in a number. This means that both the thumb and the input field would be selected, and the user can choose either to use arrow keys, or type in a number.

artboard copy 2

@davewhitley davewhitley added [Type] Enhancement A suggestion for improvement. [Feature] UI Components Impacts or related to the UI component system labels Nov 29, 2018
@chrisvanpatten
Copy link
Contributor

Can two elements have focus at once? I don't think so…

@chrisvanpatten
Copy link
Contributor

(There's an accessibility factor to consider here too since it's dealing with keyboard interaction and focus.)

@afercia
Copy link
Contributor

afercia commented Feb 28, 2019

Focus can't be on two inputs at the same time. To make things a bit more complicated, the visible <label> element is associated to the range (click on it, range get focused) while the input has only an aria-label attribute. I'd lean towards closing this issue, as there's now #14166 which aims for an overall audit the RanceControl component. Please do feel free to join the conversation there.

@afercia afercia closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants