Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeControl: if there are only 2 options, transform into a button group #12430

Open
davewhitley opened this issue Nov 29, 2018 · 3 comments
Open
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@davewhitley
Copy link
Contributor

davewhitley commented Nov 29, 2018

Is your feature request related to a problem? Please describe.
A RangeControl is sometimes used when there are only 2 options, like selecting between 1 or 2 columns in the image gallery block. This is a bad user experience because only the extreme ends of the range slider are selectable. It's hard to use. A text field is also not needed if there are only 2 options. The text field is misleading in that it seems like I can input any number I'd like.

screen shot 2018-11-29 at 9 36 30 am

Describe the solution you'd like
I suggest that we create a guideline saying that RangeControls should only be used when the options are 3 or greater.

If there are only 2, then a button group is used.

screen shot 2018-11-29 at 9 51 56 am

@davewhitley davewhitley added [Type] Enhancement A suggestion for improvement. [Feature] UI Components Impacts or related to the UI component system labels Nov 29, 2018
@Soean Soean added the Needs Design Feedback Needs general design feedback. label Nov 29, 2018
@karmatosed
Copy link
Member

karmatosed commented Nov 29, 2018

In general I agree that any binary UI shouldn't have a range slider. Galleries by default if you have over 3 image show 3. I am not sure changing the interface is the way forward here.

The text field is misleading in that it seems like I can input any number I'd like.

I agree this should be iterated on.

Is there a different interface that would work and note change when less than 3 images?

@kjellr
Copy link
Contributor

kjellr commented Apr 9, 2019

We mentioned this in the #design triage today:

https://wordpress.slack.com/archives/C02S78ZAL/p1554826903280300
(A slack login may be required to view that link)

In general, we agree. It's definitely weird to have this control max out at two choices.

It's worth noting however that in the case of the Gallery block, that control only has a max of two when you have exactly two items in a gallery. Given that caveat, it may not make technical sense to build in a separate treatment here. (Or at least, it should probably be low priority).

@karmatosed
Copy link
Member

I think we can remove the design feedback as this seems to be agreed on as to move ahead with this.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants