Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11: Enter in a paragraph loses focus. #12113

Closed
jasmussen opened this issue Nov 20, 2018 · 4 comments · Fixed by #12206
Closed

IE11: Enter in a paragraph loses focus. #12113

jasmussen opened this issue Nov 20, 2018 · 4 comments · Fixed by #12206
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@jasmussen
Copy link
Contributor

Steps to reproduce:

  • Use IE11
  • Set focus in a Paragraph
  • Type some text and press Enter
  • Note that focus is lost and you have to click the new paragraph to set focus there again

Expected result: you should just be able to keep typing.

When focus is lost, it's actually set on the body element. An additional side effect is that clicking a paragraph to type requires two clicks. The first click sets focus on the block itself (.editor-block-list__block), and the 2nd click finally sets focus where it needs to be.

This appears to have been a regression that happened between Gutenberg 3.8.1 and 3.9.1.

3.8.1 GIF of the expected behavior:

3 8 1

3.9.1 GIF of the bug:

3 9 1

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Nov 20, 2018
@mtias mtias modified the milestones: WordPress 5.0, WordPress 5.0.1 Nov 21, 2018
@afercia
Copy link
Contributor

afercia commented Nov 21, 2018

Some more details from #12180 (a duplicate of this). Worth noting this is not just about mouse interaction, but it also breaks the "Enter – create a new paragraph – just write" flow.

To me, seems the first time focus is set on the block wrapper (not on the body). I'm using a testing tool that adds a red outline to elements that receive focus:

Testing in latest master 4.5.1
Windows 10, IE 11

  • create a new post
  • enter a title
  • press Enter
  • focus is apparently moved to the default empty block:

screenshot 147

  • notice there's no visible caret
  • try to type something: nothing happens
  • expected: caret to be in the editable field and typing to work

Now, there's the need to press the Tab key to actually move focus to the editable area:

screenshot 148

  • notice the focused element is now the actual editable field
  • the caret appears initially misplaced below the editable field (tried both in Twenty Nineteen and Twenty Seventeen)
  • start typing: characters are entered in the field as expected

This happens with all the following added blocks, making the writing experience with the keyboard less than ideal.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Nov 21, 2018
@jasmussen
Copy link
Contributor Author

Perhaps should've noted here also. The following PR was the cause of the regression:

#10723

@afercia
Copy link
Contributor

afercia commented Nov 22, 2018

Please verify if the fix for this fixes also #12181

@jasmussen
Copy link
Contributor Author

💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants