Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: Consolidate onSubKey (and other helpers) to data module #11201

Open
aduth opened this issue Oct 29, 2018 · 1 comment
Open

Data: Consolidate onSubKey (and other helpers) to data module #11201

aduth opened this issue Oct 29, 2018 · 1 comment
Labels
Needs Decision Needs a decision to be actionable or relevant [Package] Data /packages/data [Type] Enhancement A suggestion for improvement.

Comments

@aduth
Copy link
Member

aduth commented Oct 29, 2018

A few higher-order reducer utilities have been implemented across Gutenberg to assist with managing @wordpress/data store reducer flows. One in particular has now been implemented identically across three modules: onSubKey:

Suggested at #9617 (comment) , perhaps we should consolidate this and other store-related reducer utilities to be an exported function of @wordpress/data. We already do this with other utilities such combineReducers.

@aduth aduth added [Type] Enhancement A suggestion for improvement. [Package] Data /packages/data labels Oct 29, 2018
@draganescu draganescu added the Needs Decision Needs a decision to be actionable or relevant label Apr 20, 2020
@paaljoachim
Copy link
Contributor

Hey @aduth Andrew.

Does this issue still have relevance?
As your away these days. I'll ping Greg @gziolo .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Decision Needs a decision to be actionable or relevant [Package] Data /packages/data [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants