Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract TextControl Wrapper from ColorPicker/DatePicker #10974

Closed
tofumatt opened this issue Oct 23, 2018 · 1 comment
Closed

Extract TextControl Wrapper from ColorPicker/DatePicker #10974

tofumatt opened this issue Oct 23, 2018 · 1 comment
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Code Quality Issues or PRs that relate to code quality

Comments

@tofumatt
Copy link
Member

There is a common use-case in the color picker and date picker for wrapping a TextControl to handle intermediate state while typing. Both the ColorPicker/DatePicker use this, so we should abstract it out.

See: #10564 (comment)
@tofumatt tofumatt added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 23, 2018
@tofumatt tofumatt mentioned this issue Oct 23, 2018
Merged
4 tasks
@adamwoodnz adamwoodnz added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jun 1, 2022
@kathrynwp
Copy link

I’m going to go ahead and close out this issue, since there hasn’t been any activity on it in over three years and work has progressed on a new color picker component over the last year: #35783.

If anyone feels it should still be looked at, please add a comment and I can take another look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tofumatt @adamwoodnz @kathrynwp