Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply editor styles inside iFrames #10547

Closed
youknowriad opened this issue Oct 12, 2018 · 1 comment
Closed

Apply editor styles inside iFrames #10547

youknowriad opened this issue Oct 12, 2018 · 1 comment
Labels
[Type] Enhancement A suggestion for improvement.
Milestone
WordPress 5.x

Comments

@youknowriad
Copy link
Contributor

Some blocks make use of iFrames as a preview (HTML block, and potential third-party markdown blocks ...). The issue is that the editor styles won't propagate there making the UI slightly different between the editor and the frontend.

Proposed solution

  • Extract the editor styles application (current in the EditorProvider component) as a reusable API.
  • Provide a way to apply these styles inside iFrames (probably give the option to drop the injected wrapper as not needed there)
@youknowriad youknowriad added [Type] Enhancement A suggestion for improvement. Future labels Oct 12, 2018
@mcsf mcsf mentioned this issue Oct 12, 2018
Merged
@mtias mtias added this to the Future: 5.1 Onwards milestone Oct 12, 2018
@youknowriad
Copy link
Contributor Author

closed by #13080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
WordPress 5.x
Development

No branches or pull requests
2 participants
@youknowriad @mtias