From eea04cf2023871351ce486b02f8749aa51085fd8 Mon Sep 17 00:00:00 2001 From: Joen Asmussen Date: Mon, 13 May 2019 12:16:15 +0200 Subject: [PATCH] Fix broken active state on formatting buttons (#15592) At some point recently a small regression was introduced to the formatting button styles where the `:active` state box shadow that is inherited from the IconButton component lingered. To reproduce in master, click and drag out on a formatting button and note a gray box shadow lingering. This PR fixes that. I'm unsure as to how the regression was introduced, but it was likely due to the rather long selectors the IconButton component uses, which would be good to refactor. --- packages/components/src/toolbar-button/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/src/toolbar-button/style.scss b/packages/components/src/toolbar-button/style.scss index 65f3c0e56c11a..b35d826ebdfc7 100644 --- a/packages/components/src/toolbar-button/style.scss +++ b/packages/components/src/toolbar-button/style.scss @@ -10,7 +10,7 @@ height: $icon-button-size; // Unset icon button styles - &:active, + &:not([aria-disabled="true"]):not(.is-default):active, &:not([aria-disabled="true"]):hover, &:not([aria-disabled="true"]):focus { outline: none;