From ccb683958d86be8881a62ee36cfb1d0703ad29a6 Mon Sep 17 00:00:00 2001
From: Marco Ciampini <marco.ciampo@gmail.com>
Date: Tue, 9 May 2023 21:46:07 +0200
Subject: [PATCH] Do not use `asChild` for indicator wrappers

---
 packages/components/src/ui/radix-dropdown/index.tsx | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/packages/components/src/ui/radix-dropdown/index.tsx b/packages/components/src/ui/radix-dropdown/index.tsx
index 5f75d1bc555d3c..4ec31a11db9bdd 100644
--- a/packages/components/src/ui/radix-dropdown/index.tsx
+++ b/packages/components/src/ui/radix-dropdown/index.tsx
@@ -189,11 +189,7 @@ export const DropdownMenuCheckboxItem = ( {
 	return (
 		<DropdownMenuStyled.CheckboxItem { ...props } checked={ checked }>
 			<DropdownMenuStyled.ItemPrefixWrapper>
-				{ /*
-					TODO: adding `asChild` seems to trigger an error due to the fact
-					that `Icon` doesn't forward refs to the underlying dom elements.
-					*/ }
-				<DropdownMenuPrimitive.ItemIndicator asChild>
+				<DropdownMenuPrimitive.ItemIndicator>
 					{ ( checked === 'indeterminate' || checked === true ) && (
 						<Icon
 							icon={
@@ -232,11 +228,7 @@ export const DropdownMenuRadioItem = ( {
 	return (
 		<DropdownMenuStyled.RadioItem { ...props }>
 			<DropdownMenuStyled.ItemPrefixWrapper>
-				{ /*
-					TODO: adding `asChild` seems to trigger an error due to the fact
-					that `Icon` doesn't forward refs to the underlying dom elements.
-					*/ }
-				<DropdownMenuPrimitive.ItemIndicator asChild>
+				<DropdownMenuPrimitive.ItemIndicator>
 					<Icon icon={ radioDot } size={ 20 } />
 				</DropdownMenuPrimitive.ItemIndicator>
 			</DropdownMenuStyled.ItemPrefixWrapper>