From c42e4d1f034ce0b2baa9a2b56cc964da227e1001 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ella=20van=C2=A0Durpe?= <ella@vandurpe.com>
Date: Wed, 19 May 2021 21:32:51 +0300
Subject: [PATCH] Rich text: remove inline display warning

---
 packages/block-library/src/file/edit.js       |  3 +--
 .../src/query-pagination-next/edit.js         |  1 -
 .../src/query-pagination-previous/edit.js     |  1 -
 .../src/site-title/edit/index.js              |  1 -
 packages/rich-text/src/component/index.js     |  2 --
 .../src/component/use-inline-warning.js       | 24 -------------------
 6 files changed, 1 insertion(+), 31 deletions(-)
 delete mode 100644 packages/rich-text/src/component/use-inline-warning.js

diff --git a/packages/block-library/src/file/edit.js b/packages/block-library/src/file/edit.js
index ad76a1c86f55c..b23502186e687 100644
--- a/packages/block-library/src/file/edit.js
+++ b/packages/block-library/src/file/edit.js
@@ -274,8 +274,7 @@ function FileEdit( {
 				) }
 				<div className={ 'wp-block-file__content-wrapper' }>
 					<RichText
-						style={ { display: 'inline-block' } }
-						tagName="a" // must be block-level or else cursor disappears
+						tagName="a"
 						value={ fileName }
 						placeholder={ __( 'Write file name…' ) }
 						withoutInteractiveFormatting
diff --git a/packages/block-library/src/query-pagination-next/edit.js b/packages/block-library/src/query-pagination-next/edit.js
index e2bb7160e4dcc..4e48c0bcecaa6 100644
--- a/packages/block-library/src/query-pagination-next/edit.js
+++ b/packages/block-library/src/query-pagination-next/edit.js
@@ -12,7 +12,6 @@ export default function QueryPaginationNextEdit( {
 		<PlainText
 			__experimentalVersion={ 2 }
 			tagName="a"
-			style={ { display: 'inline-block' } }
 			aria-label={ __( 'Next page link' ) }
 			placeholder={ __( 'Next Page' ) }
 			value={ label }
diff --git a/packages/block-library/src/query-pagination-previous/edit.js b/packages/block-library/src/query-pagination-previous/edit.js
index fed5909d10081..2c0bf33005de8 100644
--- a/packages/block-library/src/query-pagination-previous/edit.js
+++ b/packages/block-library/src/query-pagination-previous/edit.js
@@ -12,7 +12,6 @@ export default function QueryPaginationPreviousEdit( {
 		<PlainText
 			__experimentalVersion={ 2 }
 			tagName="a"
-			style={ { display: 'inline-block' } }
 			aria-label={ __( 'Previous page link' ) }
 			placeholder={ __( 'Previous Page' ) }
 			value={ label }
diff --git a/packages/block-library/src/site-title/edit/index.js b/packages/block-library/src/site-title/edit/index.js
index c93b4287cdbf2..a6438169857e1 100644
--- a/packages/block-library/src/site-title/edit/index.js
+++ b/packages/block-library/src/site-title/edit/index.js
@@ -53,7 +53,6 @@ export default function SiteTitleEdit( {
 			<TagName { ...blockProps }>
 				<RichText
 					tagName="a"
-					style={ { display: 'inline-block' } }
 					aria-label={ __( 'Site title text' ) }
 					placeholder={ __( 'Write site title…' ) }
 					value={ title }
diff --git a/packages/rich-text/src/component/index.js b/packages/rich-text/src/component/index.js
index 9bf05504fcba1..cb62992fa669a 100644
--- a/packages/rich-text/src/component/index.js
+++ b/packages/rich-text/src/component/index.js
@@ -12,7 +12,6 @@ import { apply } from '../to-dom';
 import { toHTMLString } from '../to-html-string';
 import { useDefaultStyle } from './use-default-style';
 import { useBoundaryStyle } from './use-boundary-style';
-import { useInlineWarning } from './use-inline-warning';
 import { useCopyHandler } from './use-copy-handler';
 import { useFormatBoundaries } from './use-format-boundaries';
 import { useSelectObject } from './use-select-object';
@@ -178,7 +177,6 @@ export function useRichText( {
 		ref,
 		useDefaultStyle(),
 		useBoundaryStyle( { record } ),
-		useInlineWarning(),
 		useCopyHandler( { record, multilineTag, preserveWhiteSpace } ),
 		useSelectObject(),
 		useFormatBoundaries( { record, applyRecord } ),
diff --git a/packages/rich-text/src/component/use-inline-warning.js b/packages/rich-text/src/component/use-inline-warning.js
deleted file mode 100644
index 290e84fbf25f5..0000000000000
--- a/packages/rich-text/src/component/use-inline-warning.js
+++ /dev/null
@@ -1,24 +0,0 @@
-/**
- * WordPress dependencies
- */
-import { useEffect, useRef } from '@wordpress/element';
-
-const message =
-	'RichText cannot be used with an inline container. Please use a different display property.';
-
-export function useInlineWarning() {
-	const ref = useRef();
-	useEffect( () => {
-		if ( process.env.NODE_ENV === 'development' ) {
-			const target = ref.current;
-			const { defaultView } = target.ownerDocument;
-			const computedStyle = defaultView.getComputedStyle( target );
-
-			if ( computedStyle.display === 'inline' ) {
-				// eslint-disable-next-line no-console
-				console.error( message );
-			}
-		}
-	}, [] );
-	return ref;
-}