From b23b6450292c38bc1a0dec8e905203a886f79335 Mon Sep 17 00:00:00 2001 From: Dave Smith Date: Tue, 8 Aug 2023 16:03:28 +0100 Subject: [PATCH] Remove effect dep in Link Control (#53421) * Use functional setstate to avoid dep * Remove check entirely --- .../block-editor/src/components/link-control/index.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/block-editor/src/components/link-control/index.js b/packages/block-editor/src/components/link-control/index.js index efd09e6472e8b8..0de609f7c137d9 100644 --- a/packages/block-editor/src/components/link-control/index.js +++ b/packages/block-editor/src/components/link-control/index.js @@ -201,14 +201,11 @@ function LinkControl( { useCreatePage( createSuggestion ); useEffect( () => { - if ( - forceIsEditingLink !== undefined && - forceIsEditingLink !== isEditingLink - ) { - setIsEditingLink( forceIsEditingLink ); + if ( forceIsEditingLink === undefined ) { + return; } - // Todo: bug if the missing dep is introduced. Will need a fix. - // eslint-disable-next-line react-hooks/exhaustive-deps + + setIsEditingLink( forceIsEditingLink ); }, [ forceIsEditingLink ] ); useEffect( () => {