Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figcaption doesn't become translation ready #735

Closed
iamtakashi opened this issue Oct 9, 2024 · 1 comment · Fixed by #745
Closed

Figcaption doesn't become translation ready #735

iamtakashi opened this issue Oct 9, 2024 · 1 comment · Fixed by #745
Labels
bug Something isn't working

Comments

@iamtakashi
Copy link

Sample markup

<!-- wp:video {"id":158} -->
<figure class="wp-block-video"><video controls src="<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/assets/videos/tennis_video.mp4"></video><figcaption class="wp-element-caption">Rewatch one of the biggest matches in history.</figcaption></figure>
<!-- /wp:video -->

The string Rewatch one of the biggest matches in history. stays as is after saving the theme.

@matiasbenedetto
Copy link
Contributor

A potential fix for this:
#745

@matiasbenedetto matiasbenedetto moved this from Todo to Needs Review in Create Block Theme Release Planning Nov 7, 2024
@mikachan mikachan added the bug Something isn't working label Nov 11, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Create Block Theme Release Planning Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

3 participants