Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

⚛️ Remove the wp-inner-blocks wrapper #76

Closed
DAreRodz opened this issue Sep 26, 2022 · 1 comment
Closed

⚛️ Remove the wp-inner-blocks wrapper #76

DAreRodz opened this issue Sep 26, 2022 · 1 comment

Comments

@DAreRodz
Copy link
Collaborator

We need to get rid of the <wp-inner-blocks> element to avoid CSS issues like #50.

As @luisherranz proposed in #50 (comment), we can append the wp-inner-block attribute to those blocks that are the children of an interactive block.

<div class="wp-block-parent">
  <div>Some content</div>
  <div class="wp-block-child-1" wp-inner-block>Some child content</div>
  <div class="wp-block-child-2" wp-inner-block>More child content</div>
</div>

Note that we need a new attribute because:

  • using a regexp to find nodes with their class starting with wp-block-" could be not reliable enough
  • using the wp-block-type attribute would work only if children are interactive blocks as well
@luisherranz
Copy link
Member

Fixed in #77.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants