From 9c4734cbf660660b50c4b164c58aa4a3da230d00 Mon Sep 17 00:00:00 2001
From: jrfnl <jrfnl@users.noreply.github.com>
Date: Tue, 15 Aug 2017 17:14:33 +0200
Subject: [PATCH] Add sniffs to verify modifier keywords for declared methods
 and properties to `Extra`.

As proposed in proposal 2 in WordPress-Coding-Standards/WordPress-Coding-Standards/issues/ 1101

If/when it would be decided to make this explicit in the handbook, these can be moved to the `Core` ruleset.
---
 WordPress-Extra/ruleset.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/WordPress-Extra/ruleset.xml b/WordPress-Extra/ruleset.xml
index 3b6c5c39ba..9fe15f2694 100644
--- a/WordPress-Extra/ruleset.xml
+++ b/WordPress-Extra/ruleset.xml
@@ -49,6 +49,16 @@
 
 	<rule ref="WordPress-Core"/>
 
+	<!-- Verify modifier keywords for declared methods and properties in classes.
+		 https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1101 -->
+	<rule ref="Squiz.Scope.MethodScope"/>
+	<rule ref="Squiz.Scope.MemberVarScope"/>
+	<rule ref="Squiz.WhiteSpace.ScopeKeywordSpacing"/>
+	<rule ref="PSR2.Methods.MethodDeclaration"/>
+	<rule ref="PSR2.Methods.MethodDeclaration.Underscore">
+		<type>warning</type>
+	</rule>
+
 	<!-- Warn against using fully-qualified class names instead of the self keyword. -->
 	<rule ref="Squiz.Classes.SelfMemberReference.NotUsed">
 		<!-- Restore default severity of 5 which WordPress-Core sets to 0. -->