Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag use of TEMPLATEPATH and STYLESHEETPATH #97

Closed
westonruter opened this issue Oct 19, 2013 · 6 comments · Fixed by #1089
Closed

Flag use of TEMPLATEPATH and STYLESHEETPATH #97

westonruter opened this issue Oct 19, 2013 · 6 comments · Fixed by #1089
Labels
Component: Extra Type: Enhancement
Milestone
0.14.0

Comments

@westonruter
Copy link
Member

It is highly desirable to use get_template_directory() and get_stylesheet_directory() because these can be filtered by plugins, whereas constants cannot.
@grappler
Copy link
Member

We have created a Sniff as part of the WordPress-Theme ruleset. WPTT/WPThemeReview#30

@GaryJones
Copy link
Member

@westonruter Happy for this one to be closed?

@westonruter
Copy link
Member Author

Yes, because WPTRT/WordPress-Coding-Standards is going to be merged into WPCS?

@GaryJones
Copy link
Member

That's my understanding.

@grappler Is that correct?

@jrfnl
Copy link
Member

jrfnl commented Aug 3, 2017

As that particular sniff is not theme specific, but should probably be placed in the WP category, I could update it and pull it here already. It may still be quite a while before the TRT sniffs will get pulled here, so why wait ?

@GaryJones
Copy link
Member

That sounds good to me.

@jrfnl jrfnl mentioned this issue Aug 5, 2017
Merged
@jrfnl jrfnl added this to the 0.14.0 milestone Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Extra Type: Enhancement
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

New WordPress.WP.DiscouragedConstants sniff WordPress/WordPress-Coding-Standards
4 participants
@GaryJones @westonruter @jrfnl @grappler