Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition of aliased classes and namespaces should be ignored #956

Closed
johnbillion opened this issue Jun 6, 2017 · 1 comment · Fixed by #1317
Closed

Definition of aliased classes and namespaces should be ignored #956

johnbillion opened this issue Jun 6, 2017 · 1 comment · Fixed by #1317
Labels
Focus: Modern PHP
Milestone
1.0.0

Comments

@johnbillion
Copy link
Member

The following code gets flagged by the WordPress-VIP ruleset because it thinks that Link is link(), which is disallowed.

use Fieldmanager_Link as Link;

Resulting sniff error:

Filesystem writes are forbidden, you should not be using link()
(WordPress.VIP.FileSystemWritesDisallow.file_ops_link)

The sniffs should ignore the definition of aliased classes and namespaces.

Related: #764
@jrfnl
Copy link
Member

jrfnl commented Jun 6, 2017

Related #719.

Same utility function as mentioned in #719 (comment) should solve this too eventually.

@jrfnl jrfnl mentioned this issue Mar 1, 2018
Merged
@jrfnl jrfnl added this to the 1.0.0 milestone Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Focus: Modern PHP
Projects
None yet
Milestone
1.0.0
2 participants
@johnbillion @jrfnl