Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report missing escaping for PHP <?= tag #857

Closed
david-binda opened this issue Feb 28, 2017 · 4 comments
Closed

Report missing escaping for PHP <?= tag #857

david-binda opened this issue Feb 28, 2017 · 4 comments
Assignees
@david-binda
Labels
Focus: Security
Milestone
0.12.0

Comments

@david-binda
Copy link
Contributor

While the WordPress ruleset.xml is including the Generic.PHP.DisallowShortOpenTag sniff, we still should report on missing escaping in case, the <?= is used without escaping function
@westonruter westonruter self-assigned this Feb 28, 2017
@westonruter
Copy link
Member

Taking a quick stab at this…

@david-binda
Copy link
Contributor Author

@westonruter I have a PR almost ready.

@westonruter
Copy link
Member

Nevermind then 😄

@david-binda david-binda mentioned this issue Feb 28, 2017
Closed
@david-binda
Copy link
Contributor Author

Thanks for the quick response tho! It's really impressive.

@david-binda david-binda mentioned this issue Feb 28, 2017
Closed
@jrfnl jrfnl mentioned this issue Jun 30, 2017
Merged
@jrfnl jrfnl added this to the 0.12.0 milestone Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-binda david-binda

Labels
Focus: Security
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
3 participants
@westonruter @jrfnl @david-binda