Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConcatenationSpacing? #535

Closed
samwilson opened this issue Mar 8, 2016 · 5 comments
Closed

ConcatenationSpacing? #535

samwilson opened this issue Mar 8, 2016 · 5 comments

Comments

@samwilson
Copy link
Contributor

My understanding is that the string concatenation operator . should be surrounded by whitespace in WordPress code. Something like the opposite of Squiz.Strings.ConcatenationSpacing.

The docs read: "Always put spaces after commas, and on both sides of logical, comparison, string and assignment operators."
@westonruter
Copy link
Member

You are right.

@samwilson
Copy link
Contributor Author

:) I'll send a PR?

@westonruter
Copy link
Member

westonruter commented Mar 8, 2016 via email

@samwilson
Copy link
Contributor Author

Hurrah! :) Thanks for being speedy. (I'm in UTC+8 and normally feel a bit alone...)

@samwilson samwilson mentioned this issue Mar 9, 2016
Merged
@samwilson
Copy link
Contributor Author

PR submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@westonruter @samwilson