-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove problematic words from the code #1915
Comments
I've just added this issue to the 3.0 milestone. I'm pretty sure there are some public properties which people can set from a custom Changing the names of those properties will be a BC-break for end-users, so should be done in a major version (which we just happen to be working on right now). |
This was largely addressed by #2065, though a cursory word search for other potentially problematic words should still be done before the issue can be closed. |
Anyone still up for a cursory search ? If not, I suggest we close this issue as fixed. Follow-up issues can be opened if other problematic terminology would be encountered in the future. |
Using https://github.com/get-woke/woke, it detected: Expand for raw results
Other than an easy rename of
|
Is there any interest in having an ignore for the remainder of the items? A Contents of any `.wokeignore` file
...though obviously that would mean any new valid non-inclusive instances added in the future would also be skipped. We could also ignore on a current/next line basis (like PHPCS) though that then adds tooling-specific comments throughout our codebase. |
I'm hoping we all are "woke" (=empathic and humane) enough to actively prevent new occurrences coming into the codebase after this clean up action... |
I'd refrain from using |
As discussed in #1908 we should scan the code for any problematic and non-inclusive words (
whitelist/blacklist
for instance).The principles discussed in PHPCSStandards/PHPCSExtra#59 should be taken into the account. I think that sniff will be useful if included in standards for this repo 🙂
Also, a thing to look out for is pronouns in comments. I know I've done that many times (haven't checked this repo in details for this) - using
he
in comments. Like:Instead, a more inclusive version can be used
A small change that doesn't hurt anybody, but makes it a bit more inclusive.
Note to anybody who wants to point out that this is blown out of proportion, please, don't even try. While the offense is taken, not given, using non-inclusive words means creating a non-inclusive environment, and inclusivity brings diversity and a happier space to work in. And this is what we should always strive for.
The text was updated successfully, but these errors were encountered: