$wpdb->delete() can't really be cached

[JDGrimes]

Calling $wpdb->delete() is flagged as an uncached query. Of course, a delete operation can't really be cached. Same goes for update and insert. However, I do suppose that in many cases they should perhaps still be accompanied by a cache update.

So perhaps this should be left as it is, but it seems odd to me.

Related #178

[shadyvb]

The message does seem odd for such functions, tracing cache update would probably be difficult since it can be done through other function.

[JDGrimes]

The PR was merged and released in 0.3.0. I guess this is fixed.

[samwilson]

I'm still getting an error with $wpdb->delete(). I'm using the latest on the develop branch.

[samwilson]

Sorry... here's a minimal code example that triggers the error I'm getting:

<?php
/**
 * A demonstration of WPCS failing on $wpdb->delete().
 *
 * @file
 * @package phpcs
 */

$wpdb->delete();

[JDGrimes]

See b7d5416. $wpdb->delete() should probably be accompanied by a wp_cache_delete() or wp_cache_set() depending on the nature of the cache.

[JDGrimes]

So in other words, this was reverted by #400.