Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Firefox Lesson Plan Overlap issue for all languages #1936

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Oct 12, 2023

Fixed Lesson Plan Overlap Issue with Sidebar for All Languages in Firefox.

@shail-mehta
Copy link
Member Author

Fixes #1888

@jonathanbossenger jonathanbossenger added [Dev] Needs Refresh Pull request needing a refresh. and removed [Dev] Needs Review Pull request needing a review. labels May 16, 2024
@jonathanbossenger
Copy link
Collaborator

Hi @shail-mehta thank you for your PR.

There seem to be some conflicts on this PR. Would you be able to refresh it, so that we can get it merged?

Thanks

@shail-mehta shail-mehta force-pushed the firefox-lesson-plan-overlap-issue-all-language branch from 5352f40 to 9977644 Compare May 19, 2024 03:37
@shail-mehta shail-mehta reopened this May 19, 2024
@shail-mehta
Copy link
Member Author

shail-mehta commented May 19, 2024

@jonathanbossenger Thanks for the feedback.

I have Resolved Conflicts issue & also refresh the PR With current trunk.

Can you please review it?

@jonathanbossenger jonathanbossenger added [Dev] Needs Review Pull request needing a review. and removed [Dev] Needs Refresh Pull request needing a refresh. labels May 20, 2024
@ironnysh
Copy link

ironnysh commented Sep 5, 2024

The redesign resolved #1888. This PR can be closed.

CC @jonathanbossenger

@shail-mehta shail-mehta deleted the firefox-lesson-plan-overlap-issue-all-language branch September 8, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Dev] Needs Review Pull request needing a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants