Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme overridable views #7

Open
blobaugh opened this issue May 19, 2013 · 4 comments
Open

Theme overridable views #7

blobaugh opened this issue May 19, 2013 · 4 comments
Assignees

Comments

@blobaugh
Copy link
Member

Create default views in the plugin views folder but allow the themer to override view templates in the theme

@ghost ghost assigned blobaugh May 19, 2013
@BrookeDot
Copy link
Contributor

I think the idea here was to just allow the user to override this in their stylesheet. See #1 Which would be simpler than having them override the whole view.

@blobaugh
Copy link
Member Author

Similar, but not the same. That discussion dealt with the css file specifically residing in the theme directory. With this ticket everything will exist inside of the plugin. The themer will still has the ability to override the css in their own theme css files, however what happens when the elements need to be structured entirely differently or have different markup? The themer would be required to hack the plugin which would prevent the possibility of future updates and additions. What this ticket is proposing is a fairly standard practice whereby the plugin provides a default view template in the plugin and the themer has the ability to create an additional file in the theme folder that will override the template in the plugin itself.

One thing to keep in mind during this project is that any plugin we create we would also like other Meetups to be able to setup on their sites to replicate functionality that we have. This method will create the most amount of flexibility possible.

@itsananderson and @iandunn can you chime in here with your vast wisdom?

@iandunn
Copy link

iandunn commented May 20, 2013

Yeah, I think it's a good idea to let users override the view itself, in addition to letting them override the CSS. There are use cases for doing both together, and for doing either of them individually.

It's really simple to setup, but has a huge impact on extensibility for other devs.

@itsananderson
Copy link

I agree. Simple to implement, and it makes the markup much easier for theme authors to customize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants