New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualKey mode does the same as VirtualKeyTranslate #78

Closed

Sainan opened this issue Aug 4, 2024 · 0 comments · Fixed by #86

Contributor

Sainan commented Aug 4, 2024 •

edited

Loading

MapVirtualKeyA, given its lack of a layout parameter, always uses the currently active layout, so:

The MapVirtualKeyExA call for VirtualKeyTranslate is overkill.
The VirtualKey mode doesn't work as expected as it returns translated keys. The only way I found to actually implement this correctly is hardcoding a map, because loading the English (US) layout for this purpose has a lot of unintended side-effects. For reference: My implementation (the keys here are not quite HID scancodes, but close enough.)

Sainan mentioned this issue

Rewrite VirtualKey mapping to correctly handle non-translate #86

Merged

simon-wh closed this as completed in #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment