Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge nvidia-xrun-pm into nvidia-xrun #108

Merged
merged 26 commits into from
May 3, 2019

Conversation

michelesr
Copy link
Contributor

This PR merges all the changes introduced in nvidia-xrun-pm into nvidia-xrun, in particular:

  • the systemd service that takes care of turning off the GPU automatically at boot (if enabled)
  • in order to fix problems described in Turning off graphics card hangs indefinitely #105 you need to handle two devices separately, the graphic card and the PCIe controller, which ids can be configured in /etc/default/nvidia-xrun

michelesr and others added 26 commits September 4, 2018 16:52
If control is set to 'auto' and the card is idle, it won't
be detected by the rescan. This fix will make sure the card
is always detected.
Update the RPM to install the nvidia-xrun-pm systemd service.
The command to set the power controller for the PCI express controller
needs to run in every case, so the if-else needs to be removed
This starts with release 0.3.2. This also adds the new
/etc/default/nvidia-xrun configuration file.

Signed-off-by: lshort <[email protected]>
This information was outdated and referred to the
original nvidia-xrun project.

Signed-off-by: lshort <[email protected]>
Update RPM to use GitHub source
@Witko
Copy link
Owner

Witko commented May 3, 2019

Hi @michelesr ,
did you test this?:) I can't atm.
Thanks for the effort!

@Witko
Copy link
Owner

Witko commented May 3, 2019

Just thinking, maybe the turn off nvidia at boot should not be part of nvidia-xrun itself, maybe in different package it would make more sense. What do you think?

@michelesr
Copy link
Contributor Author

michelesr commented May 3, 2019

It works fine on my machine and I think there are other users that are currently using my fork (expecially the ones running newer graphic cards, as they seems to have problems with bbswitch), as I can see from the conversations on different GitHub issues in nvidia-xun.

@ekultails built the RPM spec for nvidia-xrun-pm so maybe it can help updating the upstream rpm-spec as well: at the moment he is also maintaining the COPR package while I'm maintaining the AUR package for nvidia-xrun-pm.

IMHO it makes sense to keep the systemd service implementation here as it would make the job easier for package maintainers, also without it there's no way to automatically turn off the graphic card at boot, as bbswitch was doing that so I think it makes sense to provide this service as a replacement.

@Witko
Copy link
Owner

Witko commented May 3, 2019

For me it would seem nice to have it as a separate package, list it as optional dependency. But for now lets keep it here.

@Witko Witko merged commit 755d612 into Witko:master May 3, 2019
@michelesr michelesr deleted the realign-with-upstream branch May 3, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants