Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collection] Use PropertyPath #28

Closed
Taluu opened this issue Jul 26, 2014 · 0 comments
Closed

[Collection] Use PropertyPath #28

Taluu opened this issue Jul 26, 2014 · 0 comments

Comments

@Taluu
Copy link
Contributor

Taluu commented Jul 26, 2014

As Symfony's ProperyAccess was integrated with the CollectionSnapshot (cf #22), and as in a collection the whole objets should look alike (collection of objects, of arrays, ...), we should not try to modify the primary parameter.

If the snapshot is used with a collection of arrays, then we should either have a PropertyPath directly fed to the pkey argument, or a valid property path either way [key]. If it is a collection of objects, then either a PropertyPath object, either a key path.

This should be way more flexible than it actually is right now, instead of doing a wild guess depending on the types of each elements fed into the collection, which could be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant