-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interested in callbacks? #66
Comments
Hi Alastair. This sounds ok. However maybe the names should be Some code is already there in Would this be an idea? |
Hi, looks like a great way to provide access to the request! What can I do to help? |
@joostvanhassel Thanks for helping out. I think that the code from @alastairtree is a good start, and maybe already enough to get this issue solved? |
@StefH the changes as proposed by @alastairtree do fully cover what I would like to do for now. I think it is good to take these changes in and improve later on if further if needed. |
OK. |
Added to the source-code. |
@StefH thanks - this looks pretty good! Been thinking about syntax a bit, it is worth adding an overload on the
|
I have added a PR and test to show what i mean, see #102 |
Hello again.
Having played with the API a bit I was struggling to implement a stub where I needed a tiny bit more logic in creating the response, for example to do string manipulation on the request in a more granular way than handlebars, or in generating new IDs say.
I have experimented with a callback API like this:
The minimal implementation is in my fork, see the comparison: https://github.com/WireMock-Net/WireMock.Net/compare/master...alastairtree:feat/callbacks?expand=1
Is this something you would be interested in? Happy to do some extra work if needed to get something like it adopted. I noticed it also came up in Mock4net (alexvictoor/mock4net#19)
Thanks for the great library
Alastair
The text was updated successfully, but these errors were encountered: