WithCallback circumvent the rest of the builder

[rlf]

Describe the bug

The code-line listed here:

WireMock.Net/src/WireMock.Net/ResponseBuilders/Response.cs

Line 374 in ebb9f12

if (!WithCallbackUsed)

Effectively disables part of the builder - which IMO ruins the builder-pattern for the response builder.

Expected behavior:

I would expect the following code:

Response.Create()
  .WithCallback(req => new ResponseMessage())
  .WithStatusCode(HttpStatusCode.Created)
  .WithHeader("X-UserId", "NA")

to generate a responsemessage with what-ever the callback provides, but with the status-code Created and the additional header X-UserId.

Test to reproduce

Create any Given().RespondWith() chain that mixes both WithCallback and other builder-inputs.
Verify the Callback short-circuits anything else you put into the Builder-pattern.

I do get, how-ever, that if the callback changes the default value of say the Status - that status should prevail - but not if you specifically add a non-default status to your response, using the builder.

Other related info

None that I can think of.

[StefH]

@rlf I understand your issue.

I cannot remember anymore why I decided that WithCallback does behave like this.
(Maybe I thought that you want to do all logic in the callback, so also defining the status-codes and headers)

However, I see that in that case the fluentbuilder should not return a chainable thing so that it seems that you can add more fluent methods.

I'll check if it's easy to change that all additional .WIth*** are used.

[StefH]

Hello @rlf,

Can you please try preview NuGet WireMock.Net.1.4.6-ci-14668 from MyGet (https://github.com/WireMock-Net/WireMock.Net/wiki/MyGet-preview-versions)? This should fix your issue.

[StefH]

Dear @rlf ; did you have time to test this?

[rlf]

Verified. At least the tests I wrote when discovering this bug is now green.
Thanks!
Awesome work man!

[StefH]

@rlf Thank you for testing.

I'll release a new official version today.