Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluguide missing traits #1967

Closed
Cellcubed opened this issue Nov 19, 2020 · 7 comments · Fixed by #1969
Closed

bluguide missing traits #1967

Cellcubed opened this issue Nov 19, 2020 · 7 comments · Fixed by #1969

Comments

@Cellcubed
Copy link
Contributor

Cellcubed commented Nov 19, 2020

I noticed 3 missing traits in bluguide. The missing traits are Evasion bonus, Resist Silence, and Resist Slow. These are listed in the traits.lua but for some reason not showing up in the UI. I looked at all the code to see if I could fix it but it's too advanced for me. I also noticed voracious trunk has the wrong id in traits.lua. I changed mine from 576 to 579 and voracious trunk works as intended now but still missing the 3 traits.

@RubenatorX
Copy link
Collaborator

couple of things to note:

  1. it will only show traits associated with spells you know, so if you are missing spells then, you may not see all traits
  2. depending on the resolution of your screen, some traits will overflow off the right side of the screen as well. Minimizing trait sections can help reveal more

@Cellcubed
Copy link
Contributor Author

Thank you for taking the time to read my issue and respond.

To your first note: The addon does show me traits that I don't currently know the spells for. It also isn't showing the traits that I listed even though I do have those spells.

To your second note: I noticed this as well and have minimized every trait just to be certain.

Do you see the traits, Evasion bonus, resist silence, and resist slow on your screen while using this addon?

@RubenatorX
Copy link
Collaborator

RubenatorX commented Nov 19, 2020

Do you see the traits, Evasion bonus, resist silence, and resist slow on your screen while using this addon?

My blue mage is lvl 36, so no, I only see 7 traits

@Cellcubed
Copy link
Contributor Author

Cellcubed commented Nov 19, 2020

Well my addon shows every trait except the 3 I listed. My blue mage is 99. I have spent many hours using these addons. This is a real bug. The addon also lists the number of spell slots incorrectly at certain levels before 71, due to the author of the addon using subjoblevel for a calculation instead of mainjoblevel.

@Cellcubed
Copy link
Contributor Author

Cellcubed commented Nov 19, 2020

After finding voracious trunk had an incorrect id number, I compared every spell id in traits.lua and spellinfo.lua to Windower/res/spells.lua. I did not find any other discrepancies. I am assuming the ids are correct in windower/res/spells.lua. However, seeing two different blue mage addons not function as intended makes me wonder if the spell ids are all correct. Or perhaps something has changed that has caused addons to not see correctly which spells you have learned. On the other hand, //spbk seems to be working correctly for blue mage so maybe it's just the code for bluguide and BLUAlert

@Cellcubed
Copy link
Contributor Author

Cellcubed commented Nov 19, 2020

I have solved the missing traits problem. How can I add these changes so that other users can download the fixed code? In bluguide.lua, 3 lines must be added, 1 for each trait that doesn't appear. The list of traits starts at line 102. I'm very new to github, I only created this account for issues with windower addons. I have made the appropriate edits and created pull requests for the errors I found with this addon. Sorry if I did anything weird, not sure what a pull request is but i did it in the hopes of this fix getting out to other blue mages.

@Nifim
Copy link
Contributor

Nifim commented Nov 23, 2020

Closed with PR #1970

@Nifim Nifim closed this as completed Nov 23, 2020
@Nifim Nifim linked a pull request Nov 23, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants