code cleanup and adding randBytes() #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
reviewed
Aug 14, 2019
src/vxworks/mod.rs
Outdated
| @@ -2167,6 +2016,9 @@ extern { | |||
| iov: *const ::iovec, | |||
| iovcnt: ::c_int, | |||
| ) -> ::ssize_t; | |||
|
|
|||
| // randomNumGen.h | |||
| pub fn randBytes(buf: *mut u8, length: i32) -> i32; | |||
There was a problem hiding this comment.
For consistency you should use pub fn randBytes(buf: *mut ::c_uchar, length: ::c_int) -> c_int (or whatever types you have in randomNumGen.h).
BaoshanPang
force-pushed
the
bpang-issue1469
branch
2 times, most recently
from
3aa5260
to
1888cbd
Compare
|
Let's add randABytes and randUBytes too. I need to check which of these is the best to use in the rand crate. |
BaoshanPang
force-pushed
the
bpang-issue1469
branch
from
1888cbd
to
73dee2c
Compare
Sure. |
n-salim
reviewed
Aug 15, 2019
BaoshanPang
force-pushed
the
bpang-issue1469
branch
from
73dee2c
to
0d12127
Compare
BaoshanPang
commented
Aug 15, 2019
src/vxworks/mod.rs
Outdated
| pub fn randBytes(buf: *mut c_uchar, length: c_int) -> c_int; | ||
| pub fn randABytes(buf: *mut c_uchar, length: c_int) -> c_int; | ||
| pub fn randUBytes(buf: *mut c_uchar, length: c_int) -> c_int; | ||
| pub fn randSecure() -> BOOL; |
There was a problem hiding this comment.
@n-salim
Should I change BOOL to c_int ? althoug the BOOL is defined as c_int here.
There was a problem hiding this comment.
Yes make it c_int to align to the proposed future signature.
…askDelay() 2. change armv7-wrs-vxworks to armv7-wrs-vxworks-eabihf 3. code cleanup
BaoshanPang
force-pushed
the
bpang-issue1469
branch
from
0d12127
to
c282904
Compare
n-salim
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address: