Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

555-sighting-encounter-search #559

Merged
merged 4 commits into from
Sep 20, 2023
Merged

555-sighting-encounter-search #559

merged 4 commits into from
Sep 20, 2023

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Sep 19, 2023 •
edited
Loading

  1. now user can search sightings by encounter species/sex/custom fields.
  2. abstract logic about checking the type/filter of custom fields to a hook and reuse the hook in sightings/encounters/individuals search schemas
  3. fix a lint error about nesting ternary expressions
  4. comment out some code about displaying encounter images count and individual info on sightings search page, because currently we don't have that in BE returned data

covers issue #555

@erinz2020 erinz2020 marked this pull request as ready for review September 20, 2023 15:30
@erinz2020 erinz2020 requested a review from naknomum September 20, 2023 15:45
@erinz2020 erinz2020 linked an issue Sep 20, 2023 that may be closed by this pull request
Sighting search - Encounter field UI integration #555
Closed
naknomum
naknomum approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@erinz2020 erinz2020 force-pushed the 555-sighting-encounter-search branch from f2bc555 to 03a8f94 Compare September 20, 2023 17:19
@erinz2020 erinz2020 merged commit 12588d6 into develop Sep 20, 2023
2 of 3 checks passed
@erinz2020 erinz2020 deleted the 555-sighting-encounter-search branch January 2, 2024 01:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@naknomum naknomum naknomum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sighting search - Encounter field UI integration
2 participants
@erinz2020 @naknomum