Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

dex 1343 - clear collaboration failure after success #445

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

Emily-Ke
Copy link
Contributor

Pull request checklist:

  • Features and bugfixes should be PRed into the develop branch, not main
  • All text is internationalized
    • The error description is not internationalized, but that is beyond the scope of this checklist
  • There are no linter errors
  • New features support all states (loading, error, etc) No new features

Which JIRA ticket(s) and/or GitHub issues does this PR address?

  • DEX-1343 - Failed collaboration create does not get cleared on next success
  • It also makes a two additional changes in the same file that are not in a JIRA ticket or GitHub issue.

Pull Request Overview

  • Clears the POST request's error and success state as well as the form's error state when a new form submission is processed. Also clears the success state when the success alert is dismissed and the error states when the error alert is dismissed.
  • Changes the error alert to use the description prop instead of passing the error string as a child.
  • Updates both alerts so that they have the same styles.
previously now
previous-error-and-success new-error-and-success

new-error

new-success

  • Updates the getOptionSelected logic for each Autocomplete component, which resolves this warning
useAutocomplete.js:249 Material-UI: The value provided to Autocomplete is invalid.
None of the options match with `// provided value`.
You can use the `getOptionSelected` prop to customize the equality test.

@Emily-Ke Emily-Ke marked this pull request as ready for review August 15, 2022 22:06
@Emily-Ke Emily-Ke requested a review from brmscheiner August 15, 2022 22:06
@Emily-Ke Emily-Ke merged commit a5b1412 into develop Aug 16, 2022
@Emily-Ke Emily-Ke deleted the dex-1343-clear-collaboration-failure-after-success branch August 16, 2022 22:08
@Atticus29 Atticus29 mentioned this pull request Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants