Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Add plugin to help find unuse files, remove some files #417

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

brmscheiner
Copy link
Contributor

Pull request checklist:

  • Features and bugfixes should be PRed into the develop branch, not main
  • All text is internationalized
  • There are no linter errors
  • New features support all states (loading, error, etc)

Thanks for keeping it clean! Feel free to merge your own pull request after it has been approved - just use the "squash & merge" option.

Copy link
Contributor

@Emily-Ke Emily-Ke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused-webpack-plugin hasn't been updated in two and a half years. It also only has 9 reported issues though. Would you rather use something that is more actively maintained?

Some of the images that were removed are used as mock data in the components that you didn't remove. Was that intentional?

Copy link
Contributor

@Atticus29 Atticus29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brmscheiner
Copy link
Contributor Author

@Emily-Ke i did play around with a couple other libraries, unused-files-webpack-plugin and webpack-unused. but in the end this was the one that i got working really easily and it seems to be working fine. maybe i should take a quick look at the open issues and see if anything looks damaging

i am okay with losing the mock data, just wanted to keep the UI elements that we might use later. probably could clean up more soon

@brmscheiner
Copy link
Contributor Author

ok, i looked at the issues and didn't find anything serious. mostly just feature requests and a couple people who couldn't get it working for them.

@brmscheiner brmscheiner merged commit d97eb70 into develop Jul 7, 2022
@brmscheiner brmscheiner deleted the unused-files branch July 7, 2022 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants