Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble with current OD version #1

Open
ljournot opened this issue Mar 13, 2020 · 4 comments
Open

Trouble with current OD version #1

ljournot opened this issue Mar 13, 2020 · 4 comments

Comments

@ljournot
Copy link

Hi.
I am a biologist with very basic skills in programing and a newbie to Julia. It could be worse, e.g. I could be French.
I failed to install the OnionDecomposition package. I think part of the problem arose from the fact I'm using Julia 1.3 and the package was written for Julia 0.x, e.g. 'typealias' is deprecated.
Are you aware of an updated version of the OD package ?
Best,
laurent

@WilCrofter
Copy link
Owner

Hi @ljournot. We should be able to make OnionDecomposition compatible with Julia 1.3. I haven't looked at it in years, but there's nothing fancy going on. I'll look at it in the next day or two and keep you posted.
I'm a retired mathematician but have worked in biology. My grandfather was French and we love Paris :-).

@WilCrofter
Copy link
Owner

I have just had a quick look at the OnionDecomposition code. Making it compatible with Julia 1.3 should be an hour's work at most. The code does not seem mature or well tested, but I'm willing to work with you on it if it seems useful to you.

@WilCrofter
Copy link
Owner

The package now loads and tests for me in Julia 1.3.1. It may even be correct, but let's keep the issue open until we're more confident.

@ljournot
Copy link
Author

Hi @WilCrofter

I contacted you last year and you very kindly made the OnionDecomposition code compatible with Julia 1.3.1. At that time, I was not able to install the OnionDecomposition package using the regular Pkg.add function. As I didn't dare to bother you again, I just copied your code and pasted it in my notebooks. Everything was working fine and my project progressed thanks to you.

I recently installed the new Julia 1.7.0 version and the packages I most frequently use. Because I am just starting a new project, I thought I should do something for OnionDecomposition installation. So I forked the package on my GitHub and manually modified the Project.toml file to add 3 lines (
name = "OnionDecomposition"
uuid = "e88fc79d-5f37-4a97-b721-ea3573eae211"
version = "0.1.2"
) just to see if it works (the error message I got after Pkg.add made reference to the missing 'name'). The package installed straightforwardly and everything seems ok (I generated the uuid using the Julia UUIDs package and just added a fancy version number).

I thought I should mention this to you so that you can modify the Project.toml file on your GitHub to make the package readily usable by others. I've seen a Python version of your package (https://github.com/junipertcy/onion_decomposition), suggesting that others wish to 'peel onions'.

This may also be the right time to close this issue?

Mille mercis pour voter aide.

Laurent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants